Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Progress on demo app #414

Merged
merged 7 commits into from
Jun 6, 2024
Merged

Progress on demo app #414

merged 7 commits into from
Jun 6, 2024

Conversation

breedx-splk
Copy link
Contributor

This attempts to flesh out a little more behavior in the demo app:

  • make the session id selectable so that the id can be copied
  • add exit button in "store" to return to intro screen
  • add fake clients for loading product list and loading images
  • display scrollable list of products names, with image and price

@breedx-splk breedx-splk requested a review from a team June 5, 2024 21:37
bidetofevil
bidetofevil approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine for a demo app. If this were real I'd have some additional comments but LGTM for what it is.

Might be nice to break out things you want to have in here into issues so folks looking to contribute can pick them up?

@breedx-splk breedx-splk merged commit ca7e95f into open-telemetry:main Jun 6, 2024
3 checks passed
@breedx-splk breedx-splk mentioned this pull request Jun 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LikeTheSalad LikeTheSalad LikeTheSalad approved these changes

@marandaneto marandaneto marandaneto approved these changes

@bidetofevil bidetofevil bidetofevil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@breedx-splk @bidetofevil @marandaneto @LikeTheSalad