Instrumentation API - Part 1 #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breedx-splk
approved these changes
May 30, 2024
android-agent/src/main/java/io/opentelemetry/android/instrumentation/AndroidInstrumentation.kt
Outdated
Show resolved
Hide resolved
android-agent/src/main/java/io/opentelemetry/android/instrumentation/AndroidInstrumentation.kt
Outdated
Show resolved
Hide resolved
...ent/src/main/java/io/opentelemetry/android/instrumentation/AndroidInstrumentationRegistry.kt
Outdated
Show resolved
Hide resolved
...src/main/java/io/opentelemetry/android/instrumentation/AndroidInstrumentationRegistryImpl.kt
Show resolved
Hide resolved
...src/main/java/io/opentelemetry/android/instrumentation/AndroidInstrumentationRegistryImpl.kt
Show resolved
Hide resolved
...test/java/io/opentelemetry/android/instrumentation/AndroidInstrumentationRegistryImplTest.kt
Outdated
Show resolved
Hide resolved
...test/java/io/opentelemetry/android/instrumentation/AndroidInstrumentationRegistryImplTest.kt
Outdated
Show resolved
Hide resolved
…tation/AndroidInstrumentation.kt Co-authored-by: jason plumb <[email protected]>
…tation/AndroidInstrumentation.kt Co-authored-by: jason plumb <[email protected]>
…tation/AndroidInstrumentationRegistry.kt Co-authored-by: jason plumb <[email protected]>
marandaneto
reviewed
May 31, 2024
Comment on lines
22
to
24
| override fun getAll(): Collection<AndroidInstrumentation> { | ||
| return Collections.unmodifiableCollection(instrumentations.values) | ||
| } |
There was a problem hiding this comment.
Any reason to use the Java Collection types instead of the Kotlin ones?
There was a problem hiding this comment.
Do you mean kotlin.collections.Collection?
There was a problem hiding this comment.
yep, the kotlin.collections package in general.
The less we depend on java.* the easier it'll be to be KMP compatible in the future
There was a problem hiding this comment.
Good point. I was looking for a Collections.unmodifiableCollection equivalent, though it seems like toList should do. I've just made the changes. Cheers!
marandaneto
reviewed
May 31, 2024
...src/main/java/io/opentelemetry/android/instrumentation/AndroidInstrumentationRegistryImpl.kt
Show resolved
Hide resolved
marandaneto
reviewed
May 31, 2024
...test/java/io/opentelemetry/android/instrumentation/AndroidInstrumentationRegistryImplTest.kt
Outdated
Show resolved
Hide resolved
…tation/AndroidInstrumentationRegistryImpl.kt Co-authored-by: Manoel Aranda Neto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part - Creating the API