-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update dependency androidx.core:core-ktx to v1.13.1 - autoclosed #342
Conversation
I see, it seems like Compose is so special that it has its own compiler, which is very strict with what Kotlin versions it should run on, to the point that it will refuse to compile if the Kotlin version is newer than the latest compatible version tested with the Compose compiler..... Android ☕ It seems like the CI takes the sample app into account to run the PR checks, which is why it needs to run the compose compiler, which gives us a couple of options:
WDYT @breedx-splk ? |
Ugh. Having the demo-app as a separate project I think will work around this problem, but I dislike it for a few reasons:
This is also an interesting read: renovatebot/renovate#18354 Would it really be a big deal to hold out on the version of kotlin (minor version) until compose can handle it? I wonder how much it lags in reality.... Also, I wonder if it would be possible to build the demo app with the older version of the kotlin complier. It might complicate the conventions or make us have to break the conventions in the demo app, but that might be a nicer approach? |
I did a prototype of what it looks like to break the conventions for the demo app in order to get the build working again. Please take a look: #352 |
Ok so yeah I closed that other draft PR because I couldn't get the build to work with two versions of the gradle kotlin plugin on the classpath. It seems like it's expressly forbidden or blocked or just a plain ol' classpath limitation. In any case, seems not to work. I also spent some time trying to get a composite build working to no avail. If you care to look at what I started I pushed it here: https://github.com/breedx-splk/opentelemetry-android/tree/demo_break_conventions_composite |
4a14f85
to
2bb3f4b
Compare
This PR contains the following updates:
1.13.0
->1.13.1
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.