Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global attributes supplier #135

Merged

Conversation

breedx-splk
Copy link
Contributor

Resolves #128.

Provides the ability to pass a Supplier to the GlobalAttributesSpanAppender. This allows a user to more readily change the "global" set of attributes that are always applied to spans.

@breedx-splk breedx-splk requested a review from a team October 31, 2023 22:29
Copy link
Contributor

@LikeTheSalad LikeTheSalad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@breedx-splk breedx-splk merged commit a6afa4d into open-telemetry:main Nov 2, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config support for dynamic global attributes
2 participants