Add support for detached signatures #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves open-telemetry#65 - Added signature field to DownloadableFile message. - Added a short explanation about how the signature field can be used for detached signatures.
pmm-sumo
approved these changes
Mar 8, 2022
tigrannajaryan
added a commit
to tigrannajaryan/opamp-go
that referenced
this pull request
Mar 9, 2022
Implement spec change open-telemetry/opamp-spec#69
tigrannajaryan
added a commit
to open-telemetry/opamp-go
that referenced
this pull request
Mar 18, 2022
Implement spec change open-telemetry/opamp-spec#69
dsvanlani
added a commit
to observIQ/opamp-spec
that referenced
this pull request
Mar 22, 2022
* Add support for detached signatures (open-telemetry#69) Resolves open-telemetry#65 - Added signature field to DownloadableFile message. - Added a short explanation about how the signature field can be used for detached signatures. * Set instance_uid by Server on conflict or request for generation (open-telemetry#63) This is a first approach towards open-telemetry#56 It assumes that Agent's `instance_uid` can always be updated by Server (since resolving potential issues with conflicts is important). There's a gap with multiplexed websocket connections which perhaps could be handled by adding Agent capability flag indicating if overrides can be accepted or not Co-authored-by: Tigran Najaryan <[email protected]> Co-authored-by: Przemek Maciolek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #65
for detached signatures.