Eliminate oneof Body from AgentToServer #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This eliminates oneof Body from AgentToServer and puts all fields in AgentToServer which allows to include multiple messages in one AgentToServer. This can reduce the number of roundtrips and makes it uniform with ServerToAgent. Resolves open-telemetry#43
pmm-sumo
approved these changes
Nov 30, 2021
carlosalberto
approved these changes
Nov 30, 2021
tigrannajaryan
added a commit
to tigrannajaryan/opamp-go
that referenced
this pull request
Nov 30, 2021
This eliminates oneof Body from AgentToServer and puts all fields in AgentToServer which allows to include multiple messages in one AgentToServer. This can reduce the number of roundtrips and makes it uniform with ServerToAgent. Implements changes corresponding to spec changes open-telemetry/opamp-spec#44
tigrannajaryan
added a commit
to tigrannajaryan/opamp-go
that referenced
this pull request
Nov 30, 2021
This eliminates oneof Body from AgentToServer and puts all fields in AgentToServer which allows to include multiple messages in one AgentToServer. This can reduce the number of roundtrips and makes it uniform with ServerToAgent. Implements changes corresponding to spec changes open-telemetry/opamp-spec#44
|
cc @djaglowski if you want to have a look before I merge. |
tigrannajaryan
added a commit
to open-telemetry/opamp-go
that referenced
this pull request
Dec 1, 2021
This eliminates oneof Body from AgentToServer and puts all fields in AgentToServer which allows to include multiple messages in one AgentToServer. This can reduce the number of roundtrips and makes it uniform with ServerToAgent. Implements changes corresponding to spec changes open-telemetry/opamp-spec#44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eliminates oneof Body from AgentToServer and puts all fields in AgentToServer
which allows to include multiple messages in one AgentToServer. This can reduce
the number of roundtrips and makes it uniform with ServerToAgent.
Resolves #43