Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate DataForAgent message #42

Merged

Conversation

tigrannajaryan
Copy link
Member

Resolves #39

The DataForAgent message is unnecessary. Moved all fields from DataForAgent
to ServertoAgent and deleted DataForAgent.

Resolves open-telemetry#39

The DataForAgent message is unnecessary. Moved all fields from DataForAgent
to ServertoAgent and deleted DataForAgent.
@tigrannajaryan tigrannajaryan requested a review from a team November 30, 2021 01:49
tigrannajaryan added a commit to tigrannajaryan/opamp-go that referenced this pull request Nov 30, 2021
The DataForAgent message is unnecessary. Moved all fields from DataForAgent
to ServertoAgent and deleted DataForAgent.

Implements spec change open-telemetry/opamp-spec#42
Copy link
Contributor

@pmm-sumo pmm-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how it simplifies things

@tigrannajaryan tigrannajaryan merged commit 5e4b06a into open-telemetry:main Nov 30, 2021
@tigrannajaryan tigrannajaryan deleted the remove-dataforagent branch November 30, 2021 15:16
tigrannajaryan added a commit to open-telemetry/opamp-go that referenced this pull request Nov 30, 2021
The DataForAgent message is unnecessary. Moved all fields from DataForAgent
to ServertoAgent and deleted DataForAgent.

Implements spec change open-telemetry/opamp-spec#42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should DataForAgent be eliminated?
3 participants