Change addons and agent packages to only contain one downloadable file #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrannajaryan
commented
Nov 16, 2021
Resolves open-telemetry#5 This simplifies the protocol a bit and does not prevent the Agents to have addons or packages that are actually composed of multiple files (which can be stored in e.g. a zip or tar downdloadable file).
tigrannajaryan
force-pushed
the
one-downloadable-file
branch
from
1ff2121 to
d09bc8a
Compare
pmm-sumo
approved these changes
Nov 17, 2021
djaglowski
approved these changes
Nov 17, 2021
tigrannajaryan
added a commit
to tigrannajaryan/opamp-go
that referenced
this pull request
Nov 17, 2021
Implements spec change open-telemetry/opamp-spec#29 This simplifies the protocol a bit and does not prevent the Agents to have addons or packages that are actually composed of multiple files (which can be stored in e.g. a zip or tar downdloadable file).
tigrannajaryan
added a commit
to tigrannajaryan/opamp-go
that referenced
this pull request
Nov 17, 2021
Implements spec change open-telemetry/opamp-spec#29 This simplifies the protocol a bit and does not prevent the Agents to have addons or packages that are actually composed of multiple files (which can be stored in e.g. a zip or tar downdloadable file).
tigrannajaryan
added a commit
to open-telemetry/opamp-go
that referenced
this pull request
Nov 17, 2021
#14) Implements spec change open-telemetry/opamp-spec#29 This simplifies the protocol a bit and does not prevent the Agents to have addons or packages that are actually composed of multiple files (which can be stored in e.g. a zip or tar downdloadable file).
tigrannajaryan
added a commit
to tigrannajaryan/opamp-go
that referenced
this pull request
Nov 18, 2021
This reflects the spec change to have only one downloadable file: open-telemetry/opamp-spec#29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5
This simplifies the protocol a bit and does not prevent the Agents to
have addons or packages that are actually composed of multiple files (which
can be stored in e.g. a zip or tar downdloadable file).