Amend field names in TLSCertificate message #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paschalis Tsilias <[email protected]>
|
Please also make the same changes in https://github.com/open-telemetry/opamp-spec/blob/main/specification.md |
Signed-off-by: Paschalis Tsilias <[email protected]>
Whoops, sorry for missing that 🤦♂️ Done. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #161
This PR amends two field names in TLSCertificate message, making them more descriptive. I've opted to use the shorter
certterm, to avoid confusion with the parent message which is used asTLSCertificate certificatein three places.It's my first PR to the opamp-spec repo, so let me know if there's something I'm missing, I'd be happy to fix that.