Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce heartbeats #190

Merged
merged 25 commits into from
Jul 29, 2024
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
700260f
begin heartbeat work
jaronoff97 Apr 24, 2024
df7dd11
spec
jaronoff97 May 7, 2024
5bf4782
Merge branch 'main' of github.com:open-telemetry/opamp-spec into intr…
jaronoff97 May 7, 2024
5a10b74
Merge branch 'main' of github.com:open-telemetry/opamp-spec into intr…
jaronoff97 May 7, 2024
0655586
did the thing
jaronoff97 May 7, 2024
7cb4ecc
Apply suggestions from code review
jaronoff97 May 7, 2024
2ae4799
revert some things
jaronoff97 May 8, 2024
b24c948
Merge branch 'introduce-heartbeats' of github.com:jaronoff97/opamp-sp…
jaronoff97 May 8, 2024
85af35f
Add heartbeat capability
jaronoff97 May 10, 2024
ac174a7
Update from feedback
jaronoff97 Jun 24, 2024
3c92d98
Merge branch 'main' of github.com:open-telemetry/opamp-spec into intr…
jaronoff97 Jun 24, 2024
d6abecf
feedback
jaronoff97 Jul 9, 2024
d49a956
update from feedback
jaronoff97 Jul 10, 2024
329ff3d
Update specification.md
jaronoff97 Jul 10, 2024
6a9eeb7
remove optional in spec.md
jaronoff97 Jul 23, 2024
4c18536
Merge branch 'introduce-heartbeats' of github.com:jaronoff97/opamp-sp…
jaronoff97 Jul 23, 2024
1c2dc9f
Apply suggestions from code review
jaronoff97 Jul 26, 2024
e0b4331
updates
jaronoff97 Jul 26, 2024
8534843
update retry after
jaronoff97 Jul 26, 2024
0d0ee53
more minor changes
jaronoff97 Jul 26, 2024
082c1d7
Apply suggestions from code review
jaronoff97 Jul 26, 2024
bccefa0
Updates from PR feedback for better linking
jaronoff97 Jul 29, 2024
7d50075
Merge branch 'introduce-heartbeats' of github.com:jaronoff97/opamp-sp…
jaronoff97 Jul 29, 2024
88d6b9f
Apply suggestions from code review
jaronoff97 Jul 29, 2024
85e8f08
remove extra space
jaronoff97 Jul 29, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions proto/opamp.proto
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,20 @@ message OpAMPConnectionSettings {
// This field is optional: if omitted the client SHOULD NOT use a client-side certificate.
// This field can be used to perform a client certificate revocation/rotation.
TLSCertificate certificate = 3;

// The Agent MUST periodically send an AgentToServer message if this field is set. At a minimum
// the instance_uid field MUST be set. It is recommended that the Agent also set ComponentHealth
// as well.
//
// A Polling-based HTTP Client MUST use the value as polling interval.
jaronoff97 marked this conversation as resolved.
Show resolved Hide resolved
//
// A heartbeat is used to keep a load balancer connection active AND inform the server that the Agent
jaronoff97 marked this conversation as resolved.
Show resolved Hide resolved
// is still alive and active.
//
// This field is optional:
// if omitted, a default heartbeat interval of 30 seconds should be used.
// if set to zero, the heartbeat ability will be disabled.
optional uint64 heartbeat_interval_seconds = 4;
jaronoff97 marked this conversation as resolved.
Show resolved Hide resolved
}

// The TelemetryConnectionSettings message is a collection of fields which comprise an
Expand Down
Loading
Loading