Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ComponentHealth message #168

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

mwear
Copy link
Member

@mwear mwear commented Oct 6, 2023

As discussed in #165, this PR replaces the AgentHealth message with a wire-backwards-compatible ComponentHealth message. The ComponentHealth message allows reporting health for nested sub-components, component status, and status timestamp, while retaining the fields from the original AgentHealth message.

@mwear mwear requested a review from a team October 6, 2023 23:39
@mwear mwear force-pushed the component-health branch from 321ca7f to 34ab2df Compare October 6, 2023 23:41
This commit replaces the AgentHealth message with a wire-backwards-compatible ComponentHealth
message. The ComponentHealth message allows reporting health for nested sub-components,
component status, and status timestamp, while retaining the fields from the original
AgentHealth message.
@mwear mwear force-pushed the component-health branch from 34ab2df to 3514e22 Compare October 7, 2023 03:23
Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tigrannajaryan tigrannajaryan merged commit 1eaa4c7 into open-telemetry:main Oct 13, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants