Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[editorial] spelling correction in specification.md #155

Merged
merged 1 commit into from
Jul 11, 2023
Merged

[editorial] spelling correction in specification.md #155

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions specification.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ github_project_repo: *repo
path_base_for_github_subdir:
from: content/en/docs/specs/opamp/index.md
to: specification.md
spelling: cSpell:ignore bitmask Fluentd varint opamp
spelling: cSpell:ignore bitmask Flipr Fluentd varint opamp oneof protoc Rpbjpvc
--->

# Open Agent Management Protocol
Expand Down Expand Up @@ -667,7 +667,7 @@ is multiplexed into one WebSocket connection (for example when a terminating
proxy is used) the instance_uid field allows to distinguish which Agent the
ServerToAgent message is addressed to.

Note: the value can be overriden by Server by sending a new one in the
Note: the value can be overridden by Server by sending a new one in the
AgentIdentification field. When this happens then Agent MUST update its
instance_uid to the value provided and use it for all further communication.

Expand Down Expand Up @@ -761,7 +761,7 @@ enum ServerCapabilities {

##### ServerToAgent.agent_identification

Properties related to identification of the Agent, which can be overriden by the
Properties related to identification of the Agent, which can be overridden by the
Server if needed. When new_instance_uid is set, Agent MUST update instance_uid
to the value provided and use it for all further communication. The new_instance_uid MUST
be a [ULID](https://github.com/ulid/spec) formatted as a 26 character string in canonical
Expand Down Expand Up @@ -1641,7 +1641,7 @@ For fields which reference other messages the field is considered unset
when the reference is unset.

For primitive field (string) we rely on the "flags" to describe that the
field is not set (this is done to overcome the limitation of old protoc
field is not set (this is done to overcome the limitation of old `protoc`
compilers don't generate methods that allow to check for the presence of
the field.

Expand Down Expand Up @@ -2356,10 +2356,10 @@ The Server MAY disconnect or deny serving requests if it detects that the same
Client instance has more than one simultaneous connection or if multiple Agent
instances are using the same instance_uid.

The Server SHOULD detect duplicate instance_uids (which may happen for example
The Server SHOULD detect duplicate `instance_uid`s (which may happen for example
when Agents are using bad UID generators or due to cloning of the VMs where the
Agent runs). When a duplicate instance_uid is detected, Server SHOULD generate
a new instance_uid, and send it as new_instance_uid value of AgentIdentification.
Agent runs). When a duplicate `instance_uid` is detected, Server SHOULD generate
a new `instance_uid`, and send it as `new_instance_uid` value of AgentIdentification.

### Authentication

Expand Down