Define OpAMP Protobuf schema stability guarantees #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andykellr I am opening this draft so that we can discuss what else is necessary to resolve #134 |
|
I think this looks good. |
PeterF778
reviewed
Jan 9, 2023
The guarantees mostly mirror the proposal for OTLP (open-telemetry/opentelemetry-proto#432), the primary difference being that OpAMP has no gRPC services defined and does not need any guarantees for service definitions. Resolves open-telemetry#134
tigrannajaryan
force-pushed
the
feature/tigran/stability
branch
from
198a252 to
89b786f
Compare
tigrannajaryan
changed the title
|
OTLP Stability guarantees were merged: open-telemetry/opentelemetry-proto#432 This PR is ready for review and merging. |
jaronoff97
reviewed
May 15, 2023
| - No existing symbol will be deleted. | ||
|
|
||
| Future versions of the OpAMP specification may be extended by modifying the | ||
| Protobuf schema defined in this specification version. The following Protobuf schema |
There was a problem hiding this comment.
should we specify how deprecations will be handled for the spec?
There was a problem hiding this comment.
I haven't put anything thought into the subject of deprecations. I also don't see anything in OTLP spec to use as an inspiration. It is probably worth thinking about, but probably should be a separate PR.
jaronoff97
approved these changes
May 16, 2023
|
@andykellr please review. |
andykellr
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The guarantees mostly mirror the guarantees for OTLP (open-telemetry/opentelemetry-proto#432), the primary difference being that OpAMP has no gRPC services defined and does not need any guarantees for service definitions.
This PR reflects the OpAMP Workgroup's discussions.
Resolves #134