Change bitfields from enum to uint64 #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves open-telemetry#121 In some languages enum fields are strongly typed and it is impossible to assigned OR-ed values to the enum field. This makes impossible to compose the bit fields properly. This changes all bit field declarations from enum to uint64. The enum declarations stay, so that bit definitions are clear.
tigrannajaryan
added a commit
to tigrannajaryan/opamp-go
that referenced
this pull request
Sep 20, 2022
Implements spec change open-telemetry/opamp-spec#125 In some languages enum fields are strongly typed and it is impossible to assigned OR-ed values to the enum field. This makes impossible to compose the bit fields properly. This changes all bit field declarations from enum to uint64. The enum declarations stay, so that bit definitions are clear.
This was referenced Sep 20, 2022
andykellr
approved these changes
Sep 20, 2022
tigrannajaryan
added a commit
to open-telemetry/opamp-go
that referenced
this pull request
Sep 22, 2022
Implements spec change open-telemetry/opamp-spec#125 In some languages enum fields are strongly typed and it is impossible to assigned OR-ed values to the enum field. This makes impossible to compose the bit fields properly. This changes all bit field declarations from enum to uint64. The enum declarations stay, so that bit definitions are clear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #121
In some languages enum fields are strongly typed and it is impossible to assigned OR-ed values to the enum field. This makes impossible to compose the bit fields properly.
This changes all bit field declarations from enum to uint64. The enum declarations stay, so that bit definitions are clear.
This must be a non-breaking change on the wire. The enum and uint64 are encoded exactly the same way on the wire.