Require that instance_uid is ULID instead of only recommending it #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves open-telemetry#113 This PR changes ULID to be a `MUST` in order to: - Avoid mistakes when the Agent chooses too short instance id and causes collisions. - Make the Server's life a bit easier since will know it is always a 128 bits of data and can store in places where UUIDs can be stored (e.g. Postgres has a data type UUID).
tigrannajaryan
force-pushed
the
feature/tigran/make-ulid-required
branch
from
6746733 to
218536c
Compare
andykellr
approved these changes
Jul 28, 2022
Yes. Good news is that this seems to be the last remaining known issue that will be a breaking change. We should probably wait for a bit after merging this one to see if any other issues are discovered that will be also breaking so that we can release them at once (multiple breaking releases are usually more painful - that's why we promise no more frequently than once every 3 months when in Beta). |
tigrannajaryan
added a commit
to tigrannajaryan/opamp-go
that referenced
this pull request
Jul 29, 2022
Implements spec change open-telemetry/opamp-spec#116
tigrannajaryan
added a commit
to open-telemetry/opamp-go
that referenced
this pull request
Aug 2, 2022
Implements spec change open-telemetry/opamp-spec#116
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #113
This PR changes ULID to be a
MUSTin order to: