Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recommendations for keeping connections alive #28

Open
tigrannajaryan opened this issue Nov 16, 2021 · 4 comments
Open

Add recommendations for keeping connections alive #28

tigrannajaryan opened this issue Nov 16, 2021 · 4 comments

Comments

@tigrannajaryan
Copy link
Member

  1. Intermediaries such as load balancers may time out inactive connections. Add recommendations on how to keep it alive (either use WebSocket ping/pong or send empty status report).
  2. Explain how clients should react to disconnections. Do they re-connection immediately? When do they pause (throttling) before re-connecting?
@djaglowski
Copy link
Member

djaglowski commented Nov 17, 2021

  1. Intermediaries such as load balancers may time out inactive connections. Add recommendations on how to keep it alive (either use WebSocket ping/pong or send empty status report).

Related, the server should probably be able to specify a frequency for keep alive signals. This would allow it to adjust based on the networking environment.

  1. Explain how clients should react to disconnections. Do they re-connection immediately? When do they pause (throttling) before re-connecting?

I think we can assume there are scenarios where the client repeatedly either 1) fails to connect or 2) connects but loses it after only a moment, not long enough to receive instructions from the server. In either case, the client should probably backoff based on rate of connection attempts. I'm not sure the exact algorithm need be part of the spec, but it seems reasonable to suggest that there should be one.

@tigrannajaryan
Copy link
Member Author

Related, the server should probably be able to specify a frequency for keep alive signals. This would allow it to adjust based on the networking environment.

If we want this then it can be a field in ConnectionSettings message.

tigrannajaryan added a commit to tigrannajaryan/opamp-spec that referenced this issue Nov 18, 2021
tigrannajaryan added a commit to tigrannajaryan/opamp-spec that referenced this issue Nov 18, 2021
@tigrannajaryan
Copy link
Member Author

#36 should solve part of the problems. We may still need to add ability to instruct the Agent how often to ping/pong or send status reports to avoid disconnection due to idle timeout, so I will keep this open to address that.

@haoqixu
Copy link
Member

haoqixu commented Aug 23, 2024

This issue appears to be resolved by #190.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants