-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remote Agent restart capability #22
Comments
It seems reasonable to me to have basic control capabilities like this. I've personally required this in similar implementations and have found it useful for various troubleshooting and recovery scenarios. Similarly, a "shutdown" capability can be useful for retiring unsupported versions / zombie instances. I support both cases as long as they have corresponding capability flags. |
Is it assumed that the OpAMP connection is lost after the "shutdown"? This would mean "shutdown" is irreversible (unless the Agent us run again after e.g. machine restarts)? Alternatively, do we think of "shutdown" to be applicable when the Supervisor model is used, essentially meaning that the Supervisor stays up and running and can be instructed to start the Agent again? |
That is how I would define it. I have implemented a shutdown in a supervised model but not one where the supervisor had a connection. I'll describe that first as a possible model:
In the case where the supervisor has a connection, it may worth differentiating between the cases where a total shutdown is desired, vs waiting for further instructions. Even a standalone agent could differentiate between the two behaviors:
I'm in the weeds in relation to your original question - happy to open separate issues if more appropriate. |
Yes, I think it would be useful to separate this into a separate issue, since it seems complicated enough to warrant its own discussion. |
Resolves #22 - Add `ServerToAgentCommand` into `ServerToAgentMessage`. - Documents `ServerToAgentCommand`
Do we need a capability for the Server to order the Agent to restart?
The text was updated successfully, but these errors were encountered: