Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split connection settings by types #82

Conversation

tigrannajaryan
Copy link
Member

@tigrannajaryan tigrannajaryan commented May 20, 2022

This changes splits connection settings by the type of the connection so that
each type has a corresponding message that records the appropriate data.

Implements spec change open-telemetry/opamp-spec#87

@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #82 (4e7024d) into main (afb132b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #82   +/-   ##
=======================================
  Coverage   78.08%   78.08%           
=======================================
  Files          22       22           
  Lines        1720     1720           
=======================================
  Hits         1343     1343           
  Misses        283      283           
  Partials       94       94           
Impacted Files Coverage Δ
client/internal/receivedprocessor.go 88.78% <ø> (ø)
client/types/callbacks.go 71.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afb132b...4e7024d. Read the comment docs.

@tigrannajaryan tigrannajaryan force-pushed the feature/tigran/split-con-set branch 3 times, most recently from ddb7283 to 9782f49 Compare May 26, 2022 00:18
This changes splits connection settings by the type of the connection so that
each type has a corresponding message that records the appropriate data.

Implements spec change open-telemetry/opamp-spec#87
@tigrannajaryan tigrannajaryan force-pushed the feature/tigran/split-con-set branch from 9782f49 to 4e7024d Compare May 26, 2022 00:18
@tigrannajaryan tigrannajaryan marked this pull request as ready for review May 26, 2022 00:18
@tigrannajaryan tigrannajaryan requested a review from a team May 26, 2022 00:18
@tigrannajaryan tigrannajaryan merged commit 0403a82 into open-telemetry:main May 26, 2022
@tigrannajaryan tigrannajaryan deleted the feature/tigran/split-con-set branch May 26, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants