Add optional headers to DownloadableFile messages when downloading files #306
+42
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -280,6 +280,13 @@ func (s *packagesSyncer) downloadFile(ctx context.Context, pkgName string, file | |||
| return fmt.Errorf("cannot download file from %s: %v", file.DownloadUrl, err) | |||
| } | |||
|
|
|||
| // Add optional headers if they exist | |||
| if file.Headers != nil { | |||
There was a problem hiding this comment.
Can we verify this functionality in the tests, somewhere around
opamp-go/client/clientimpl_test.go
Line 1508 in 22263c7
There was a problem hiding this comment.
Kindly check the latest update. I did notice though that the opamp.proto file though is in a separate repo which makes it difficult for testing locally when working on this repo.
tigrannajaryan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #299
This PR implements the recent specification change that allows for optional headers in the DownloadableFile message, which can be used during file downloads to support authentication and other header-based configurations.
The downloadFile function in the packagesSyncer struct has been modified to include optional headers from the DownloadableFile message. This enhancement allows Agents to set custom HTTP headers when downloading files from the server. For instance, headers such as Authorization can now be included to facilitate secure downloads.
Changes Made:
-Updated the downloadFile method to check for the presence of optional headers in the DownloadableFile message.
-Added logic to incorporate these headers into the HTTP request when downloading files.
-Ensured compatibility with the updated protocol specification that outlines the use of headers for authentication and other purposes.