Add "fully set" flag to AgentToServer message #103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a draft PR to demonstrate how open-telemetry/opamp-spec#109 can be resolved. The new StatusIsFullSet is set by the agent the status is fully set the message. The server checks the flag to know if it needs to request the full status. This is a backward compatible change. New servers that work with old agents may make an extra request for the full status because old agents don't set this flag, but this was already a problem in the past even before this change.
|
@andykellr please take a look. |
Codecov Report
@@ Coverage Diff @@
## main #103 +/- ##
==========================================
+ Coverage 75.77% 75.80% +0.03%
==========================================
Files 22 22
Lines 1577 1579 +2
==========================================
+ Hits 1195 1197 +2
Misses 288 288
Partials 94 94
Continue to review full report at Codecov.
|
|
Closing in favour of #105 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR to demonstrate how open-telemetry/opamp-spec#109
can be resolved.
The new StatusIsFullSet is set by the agent the status is fully set the message.
The server checks the flag to know if it needs to request the full status.
This is a backward compatible change. New servers that work with old agents may
make an extra request for the full status because old agents don't set this flag,
but this was already a problem in the past even before this change.