Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added OTel contribution details for Alolita Sharma #547

Closed
wants to merge 1 commit into from

Conversation

alolita
Copy link
Member

@alolita alolita commented Oct 24, 2020

No description provided.

@bhs
Copy link
Contributor

bhs commented Oct 25, 2020

@alolita since voting opens in about 8h, I was hoping to merge this soon. In lieu of other reviewers, I just wanted to briefly verify the contributions you're referring to. Are you able to point to a few representative PRs you've made to the OTel C++ API+SDK and the prometheus work? (Just in the thread here – not suggesting that needs to go into the text of the nomination bio, to be clear)

@alolita
Copy link
Member Author

alolita commented Oct 26, 2020

Hi @bhs I manage and guide the engineering team that has contributed to OTel projects. Here are some examples of the contributions my team has made under my guidance.
open-telemetry/opentelemetry-collector#1577
open-telemetry/opentelemetry-go-contrib#205
open-telemetry/opentelemetry-cpp#191

@bhs
Copy link
Contributor

bhs commented Oct 26, 2020

I'm glad for others to jump in here, but IMO there is an important distinction between "managing a team that makes contributions" and "making those contributions oneself." So can that be clarified? Basically the difference between something like

I’ve contributed Prometheus pull and remote-write exporters for the C++, Go SDKs and the Collector.

... and ...

My team has contributed Prometheus pull and remote-write exporters for the C++, Go SDKs and the Collector.

@tedsuo
Copy link
Contributor

tedsuo commented Oct 26, 2020

Pedantic but probably correct @bhs. :)

@bhs
Copy link
Contributor

bhs commented Oct 28, 2020

@alolita congrats on your recent election to the GC! I am going to close this since voting is over...

@bhs bhs closed this Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants