-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project and SIG Proposal: Resources and Entities #1976
Project and SIG Proposal: Resources and Entities #1976
Conversation
0ad6be6
to
41eae8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of typos, but LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see comments.
We discussed this on the GC when this was filed, and again with the GC + TC today, and we have general approval for this. Anyone from the GC can merge this now, or we can wait for the GitHub discussions to close. |
This proposes a new project and SIG to introduce the concept of Entities, extend the concept of Resources in order to solve a number of long-standing well-known problems with the Resource, described in the PR and linked documents. Proposed on behalf of @tigrannajaryan and @jsuereth
97eb444
to
68a7b05
Compare
We have the approvals, so this PR is going to be merged and the project is going to be started soon. Anyone reviewing this and who would like to be part of the new SIG please feel free to express your interest by commenting. |
I'd like to be part of the SIG, please. |
Fix confusing language in mutable attributes problem definition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - from the PoV of someone implementing Prometheus support for OTel, I think the Entity concept, and especially the attempt to better discern between identifying and descriptive attributes, sounds like a step in the right direction.
We have the GC approval, all comments are resolved. Merging. |
I am at Kubecon, will kick off the project when I return. |
Hey @tigrannajaryan, I'd like to be part of this SIG. thanks |
|
I would like to participate. Thanks! |
@trask would love to be involved. |
Anyone who is interested in participating the fist SIG meeting is announced here https://cloud-native.slack.com/archives/C06QEG97W7L/p1711393987536749 |
This proposes a new project and SIG to introduce the concept of Entities, extend the concept of Resources in order to solve a number of long-standing well-known problems with the Resource, described in the PR and linked documents.
Proposed on behalf of @tigrannajaryan and @jsuereth