Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project and SIG Proposal: Resources and Entities #1976

Merged
merged 6 commits into from
Mar 19, 2024
Merged

Project and SIG Proposal: Resources and Entities #1976

merged 6 commits into from
Mar 19, 2024

Conversation

tigrannajaryan
Copy link
Member

This proposes a new project and SIG to introduce the concept of Entities, extend the concept of Resources in order to solve a number of long-standing well-known problems with the Resource, described in the PR and linked documents.

Proposed on behalf of @tigrannajaryan and @jsuereth

@tigrannajaryan tigrannajaryan force-pushed the feature/tigran/entities branch from 0ad6be6 to 41eae8a Compare February 29, 2024 16:05
jpkrohling
jpkrohling approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of typos, but LGTM.

projects/resources-and-entities.md Outdated Show resolved Hide resolved
projects/resources-and-entities.md Outdated Show resolved Hide resolved
@arminru arminru mentioned this pull request Mar 5, 2024
Open
arminru
arminru reviewed Mar 5, 2024
View reviewed changes
projects/resources-and-entities.md Outdated Show resolved Hide resolved
projects/resources-and-entities.md Outdated Show resolved Hide resolved
mtwo
mtwo approved these changes Mar 5, 2024
View reviewed changes
projects/resources-and-entities.md Outdated Show resolved Hide resolved
aknuds1
aknuds1 reviewed Mar 8, 2024
View reviewed changes
Copy link

@aknuds1 aknuds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments.

projects/resources-and-entities.md Outdated Show resolved Hide resolved
projects/resources-and-entities.md Outdated Show resolved Hide resolved
projects/resources-and-entities.md Outdated Show resolved Hide resolved
projects/resources-and-entities.md Outdated Show resolved Hide resolved
projects/resources-and-entities.md Outdated Show resolved Hide resolved
projects/resources-and-entities.md Outdated Show resolved Hide resolved
projects/resources-and-entities.md Show resolved Hide resolved
projects/resources-and-entities.md Show resolved Hide resolved
@danielgblanco danielgblanco added the area/project-proposal Submitting a filled out project template label Mar 11, 2024
@mtwo
Copy link
Member

mtwo commented Mar 14, 2024

We discussed this on the GC when this was filed, and again with the GC + TC today, and we have general approval for this. Anyone from the GC can merge this now, or we can wait for the GitHub discussions to close.

@tigrannajaryan
Project and SIG Proposal: Resources and Entities
c501458 
This proposes a new project and SIG to introduce the concept of Entities, extend the concept of Resources in order to solve a number of long-standing well-known problems with the Resource, described in the PR and linked documents.

Proposed on behalf of @tigrannajaryan and @jsuereth
@tigrannajaryan
Fix typos and add missing links
a64dc46
@tigrannajaryan
Add preliminary dates.
dadadc2
@tigrannajaryan tigrannajaryan force-pushed the feature/tigran/entities branch from 97eb444 to 68a7b05 Compare March 15, 2024 18:41
@tigrannajaryan
Copy link
Member Author

We have the approvals, so this PR is going to be merged and the project is going to be started soon.

Anyone reviewing this and who would like to be part of the new SIG please feel free to express your interest by commenting.

@aknuds1
Copy link

aknuds1 commented Mar 16, 2024

Anyone reviewing this and who would like to be part of the new SIG please feel free to express your interest by commenting.

I'd like to be part of the SIG, please.

@jsuereth
Update resources-and-entities.md
ad1ef4f 
Fix confusing language in mutable attributes problem definition.
aknuds1
aknuds1 approved these changes Mar 18, 2024
View reviewed changes
Copy link

@aknuds1 aknuds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - from the PoV of someone implementing Prometheus support for OTel, I think the Entity concept, and especially the attempt to better discern between identifying and descriptive attributes, sounds like a step in the right direction.

@tigrannajaryan
Copy link
Member Author

We have the GC approval, all comments are resolved. Merging.

@tigrannajaryan tigrannajaryan merged commit fc02ac0 into open-telemetry:main Mar 19, 2024
3 checks passed
@tigrannajaryan tigrannajaryan deleted the feature/tigran/entities branch March 19, 2024 10:04
@tigrannajaryan
Copy link
Member Author

tigrannajaryan commented Mar 19, 2024 •
edited
Loading

I am at Kubecon, will kick off the project when I return.

@iogbole
Copy link
Contributor

iogbole commented Mar 20, 2024

Hey @tigrannajaryan, I'd like to be part of this SIG. thanks

@tigrannajaryan
Copy link
Member Author

#otel-entities CNCF Slack channel created for the SIG: https://cloud-native.slack.com/archives/C06QEG97W7L

@tigrannajaryan
Copy link
Member Author

Project board: https://github.com/orgs/open-telemetry/projects/85/views/1

@chrisdistasio
Copy link

I would like to participate. Thanks!

@mlunadia
Copy link

@trask would love to be involved.

@tigrannajaryan
Copy link
Member Author

Anyone who is interested in participating the fist SIG meeting is announced here https://cloud-native.slack.com/archives/C06QEG97W7L/p1711393987536749

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeitlinger zeitlinger zeitlinger left review comments

@jsuereth jsuereth jsuereth approved these changes

@tedsuo tedsuo tedsuo left review comments

@arminru arminru arminru left review comments

@MrAlias MrAlias MrAlias approved these changes

@cijothomas cijothomas cijothomas approved these changes

@austinlparker austinlparker austinlparker approved these changes

@alanwest alanwest alanwest approved these changes

@jpkrohling jpkrohling jpkrohling approved these changes

@mtwo mtwo mtwo approved these changes

@aknuds1 aknuds1 aknuds1 approved these changes

@carlosalberto carlosalberto carlosalberto approved these changes

@svrnm svrnm svrnm approved these changes

@alolita alolita Awaiting requested review from alolita alolita is a code owner

@danielgblanco danielgblanco Awaiting requested review from danielgblanco danielgblanco is a code owner

@dyladan dyladan Awaiting requested review from dyladan

@trask trask Awaiting requested review from trask trask is a code owner

Assignees
No one assigned
Labels
area/project-proposal Submitting a filled out project template
Projects
🔭 Main Backlog
Status: Current Projects
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.