Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run & fix linters flake8, pylint, mypy #62

Merged
merged 10 commits into from
Sep 10, 2021
Merged

Run & fix linters flake8, pylint, mypy #62

merged 10 commits into from
Sep 10, 2021

Conversation

Oberon00
Copy link
Member

@Oberon00 Oberon00 commented Sep 7, 2021

This fixes errors from & runs the following linters, that are all also used in opentelemetry-python:

  • flake8 (a fast & simple linter)
  • pylint (a slow linter that does some code analysis)
  • mypy (a checker for the type annotations we already had in place)

@Oberon00 Oberon00 added cleanup Refactorings, etc, that don't add new features or fix bugs. semconv Related to the semantic convention generator. labels Sep 7, 2021
@Oberon00 Oberon00 marked this pull request as ready for review September 7, 2021 16:35
@Oberon00 Oberon00 requested a review from a team September 7, 2021 16:35
@Oberon00 Oberon00 changed the title Run & fix flake8. Run & fix linters flake8, pylint, mypy Sep 8, 2021
thisthat
thisthat approved these changes Sep 8, 2021
View reviewed changes
Copy link
Member

@thisthat thisthat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@Oberon00 Oberon00 mentioned this pull request Sep 8, 2021
Merged
@arminru arminru enabled auto-merge (squash) September 10, 2021 10:06
@arminru arminru merged commit 5175c77 into open-telemetry:main Sep 10, 2021
@Oberon00 Oberon00 deleted the feature/more-lint branch September 10, 2021 10:08
@Oberon00 Oberon00 mentioned this pull request Sep 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisthat thisthat thisthat approved these changes

@arminru arminru arminru approved these changes

Assignees
No one assigned
Labels
cleanup Refactorings, etc, that don't add new features or fix bugs. semconv Related to the semantic convention generator.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Oberon00 @thisthat @arminru