Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribute naming collisions and resolution #324

Closed
wants to merge 1 commit into from

Conversation

lmolkova
Copy link
Contributor

@lmolkova lmolkova commented Jun 9, 2024

Adds check for naming conflicts:

  1. Code generation (Code generation: how to avoid naming collisions semantic-conventions#1118)
    • fails when 2+ non-deprecated attributes would result in the same const name in code
    • allows to have a deprecated and non-deprecated attribute with the same const name
  2. Namespace vs name collision (Add attribute naming checks semantic-conventions#1068)
    • fails when a non-deprecated attribute collides with a namespace of a non-deprecated attribute
    • allows collisions if one of them is deprecated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant