Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused Units, Scope, and MetricGroup conventions #309

Merged
merged 5 commits into from
May 3, 2024

Conversation

lmolkova
Copy link
Contributor

Removes unused UnitSemanticConvention, MetricGroupSemanticConvention and ScopeSemanticConvention

(part of #303)

@lmolkova lmolkova requested review from a team March 29, 2024 22:41
@joaopgrassi
Copy link
Member

Hum, is MetricGroupSemanticConvention really not used? I thought it is part of the whole metrics semconv gen. @jamesmoessis I think introduced this initially.

@lmolkova
Copy link
Contributor Author

lmolkova commented Apr 2, 2024

Hum, is MetricGroupSemanticConvention really not used? I thought it is part of the whole metrics semconv gen. @jamesmoessis I think introduced this initially.

nope, it's not and I don't quite understand what it is, but happy to learn :)

@jamesmoessis
Copy link
Contributor

It might've been used initially to group metric attributes that weren't attached to specific metrics. However, if the direction has gone elsewhere and not used it, fine to delete :)

@lmolkova
Copy link
Contributor Author

We're moving over to weaver to generate semantic conventions markdown and code and don't intend to release new version of build-tools.

So I'm going to close this PR for the time being.

@lmolkova lmolkova closed this Apr 24, 2024
@lmolkova lmolkova reopened this May 2, 2024
@lmolkova lmolkova merged commit 63502e6 into open-telemetry:main May 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants