Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds required stability property to enum members #267

Merged
merged 11 commits into from
Mar 6, 2024

Conversation

lmolkova
Copy link
Contributor

@lmolkova lmolkova commented Feb 19, 2024

See open-telemetry/semantic-conventions#670 (comment) for the context

As a part of DB and messaging semconv stability, we want to stabilize corresponding *.system attribute.
However it would affect only a subset of corresponding member values.

We need a mechanism that would allow to declare which of the constants are stable.

@lmolkova lmolkova requested review from a team February 19, 2024 01:28
@lmolkova lmolkova force-pushed the enum-member-stability branch from 9e0f4d8 to 64262bc Compare February 21, 2024 02:01
semantic-conventions/syntax.md Outdated Show resolved Hide resolved
@lmolkova lmolkova force-pushed the enum-member-stability branch 2 times, most recently from 61793f6 to 27a4590 Compare February 22, 2024 19:42
@lmolkova lmolkova changed the title Adds stability property to enum members Adds required stability property to enum members Feb 23, 2024
@lmolkova lmolkova force-pushed the enum-member-stability branch 4 times, most recently from 8fa208a to 18ad1d7 Compare February 26, 2024 22:58
@arminru arminru merged commit fe157ef into open-telemetry:main Mar 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants