-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #252
Update README.md #252
Conversation
Updated the outdated links in the readme.md file to redirect user to the semantic-conventions folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Co-authored-by: Armin Ruech <[email protected]>
Co-authored-by: Armin Ruech <[email protected]>
Redundant sentence
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to swoop in and drop a code review on a repo that I've never contributed to 🙈 But I noticed the same broken links while I going through the docs, saw this PR, and wanted to provide feedback rather than open a duplicative PR.
Accepted suggestion from wbh1 Co-authored-by: Will Hegedus <[email protected]>
Accepted suggestion from wb1.
All comments have been accepted. Please let me know if there should be any more changes. |
Accepted changes Co-authored-by: Jesse <[email protected]>
Updated the outdated links in the readme.md file to redirect user to the semantic-conventions folder.
Original issue: #34