Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #252

Merged
merged 8 commits into from
Feb 17, 2024
Merged

Update README.md #252

merged 8 commits into from
Feb 17, 2024

Conversation

kennykguo
Copy link
Contributor

@kennykguo kennykguo commented Jan 5, 2024

Updated the outdated links in the readme.md file to redirect user to the semantic-conventions folder.
Original issue: #34

Updated the outdated links in the readme.md file to redirect user to the semantic-conventions folder.
@kennykguo kennykguo requested review from a team January 5, 2024 18:44
Copy link
Member

@arminru arminru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

semantic-conventions/README.md Outdated Show resolved Hide resolved
semantic-conventions/README.md Show resolved Hide resolved
semantic-conventions/README.md Outdated Show resolved Hide resolved
@arminru arminru linked an issue Jan 9, 2024 that may be closed by this pull request
kennykguo and others added 3 commits January 18, 2024 18:30
Copy link
Contributor

@wbh1 wbh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to swoop in and drop a code review on a repo that I've never contributed to 🙈 But I noticed the same broken links while I going through the docs, saw this PR, and wanted to provide feedback rather than open a duplicative PR.

semantic-conventions/README.md Outdated Show resolved Hide resolved
semantic-conventions/README.md Show resolved Hide resolved
semantic-conventions/README.md Outdated Show resolved Hide resolved
kennykguo and others added 2 commits January 23, 2024 20:12
Accepted suggestion from wbh1

Co-authored-by: Will Hegedus <[email protected]>
Accepted suggestion from wb1.
@kennykguo
Copy link
Contributor Author

All comments have been accepted. Please let me know if there should be any more changes.

semantic-conventions/README.md Outdated Show resolved Hide resolved
semantic-conventions/README.md Show resolved Hide resolved
Accepted changes

Co-authored-by: Jesse <[email protected]>
@jsuereth jsuereth merged commit 4a04fca into open-telemetry:main Feb 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code generator readme is outdated
7 participants