Add link to requirement levels on Markdown table headers #222
Conversation
semantic-conventions/src/opentelemetry/semconv/templating/markdown/__init__.py
Show resolved
Hide resolved
semantic-conventions/src/opentelemetry/semconv/templating/markdown/__init__.py
Outdated
Show resolved
Hide resolved
joaopgrassi
changed the title
|
@lmolkova I took the liberty to update this PR and addressed the issue with the PR title. What is else blocking in merging this? |
thanks a lot!! |
lmolkova
force-pushed
the
http-proofreading
branch
2 times, most recently
from
6d6dcf0 to
882376a
Compare
|
@open-telemetry/specs-semconv-maintainers can it be merged? |
lmolkova
force-pushed
the
http-proofreading
branch
from
3ce1edf to
259d71a
Compare
|
@open-telemetry/specs-semconv-maintainers can it be merged? |
|
@lmolkova I think we still need to address the comments about the link to the spec https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/common/attribute-requirement-level.md. That is moved now to semconv. But if we change the link to the semconv, then other problems appear as I have noted above. Another idea is to just link to the website instead. Then users avoid to having to click twice to get to the information. |
lmolkova
force-pushed
the
http-proofreading
branch
from
dcfa31f to
55f820f
Compare
|
@joaopgrassi great catch and great suggestion! I changed req level link to use website. We don't have a clear link to attribute types, so I removed link for types. |
semantic-conventions/src/opentelemetry/semconv/templating/markdown/__init__.py
Outdated
Show resolved
Hide resolved
semantic-conventions/src/opentelemetry/semconv/templating/markdown/__init__.py
Outdated
Show resolved
Hide resolved
semantic-conventions/src/opentelemetry/semconv/templating/markdown/__init__.py
Outdated
Show resolved
Hide resolved
Apply suggestions from open-telemetry/semantic-conventions#283