Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed conditionally_required requirement_level. #201

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Fixed conditionally_required requirement_level. #201

merged 2 commits into from
Sep 11, 2023

Conversation

jerbly
Copy link
Contributor

@jerbly jerbly commented Sep 5, 2023

The conditionally_required option for requirement_level has an error in the schema.json. This causes the vscode extension to flag an error when there is none. Here's an example from http-common:
image

The fix is simply to change the properties to match conditionally_required.

@jerbly jerbly requested review from a team September 5, 2023 19:30
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 5, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@jerbly
Copy link
Contributor Author

jerbly commented Sep 7, 2023

Hey. Thanks for all the approvals! What's the next step to get this merged?

@arminru arminru merged commit 870e84d into open-telemetry:main Sep 11, 2023
@jerbly jerbly deleted the fix-conditionally-required-in-schema-json branch September 11, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants