-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multiarch Docker images #127
base: main
Are you sure you want to change the base?
Conversation
601b87c
to
aeb81c8
Compare
is there anybody around that can approve the workflow run? @arminru ? 😅 |
fixed the error @arminru |
I need one more re-run 😅 |
The build is taking a really long time and GitHub kills it after 6 hours, maybe we could just add arm64 for now? I’m looking into cross compiling but it’s not that straightforward. |
Any update on this one? I could use this as well. |
@lucacome do you plan to work on this? I tried building from your branch but the build failed for me. |
yeah I can resume working on this @tigrannajaryan I was waiting for somebody to review it 🙂 |
@lucacome I think this needs a rebase to resolve conflicts and also because many of dockerfile dependency versions have been updated since the PR was first created. I am happy to review it. |
db75429
to
3a8e91f
Compare
@lucacome thank you for updating the PR. Sorry for late reply, I missed the notification that the PR was updated. I see that the build passes now, but I do not see anywhere in the output that it also builds the arm version. Can you help me understand? |
3a8e91f
to
23c26ed
Compare
Signed-off-by: Luca Comellini <[email protected]>
23c26ed
to
4f348f2
Compare
@tigrannajaryan I've resumed working on this. I split the two builds into two different runners but the arm64 still takes 3.5 hours. I'm looking into cross-compiling but it's not been very successful. Not sure if we still want to merge this in the meantime to start building for arm64. It shouldn't be too bad once everything is cached if there aren't too many changes. |
@lucacome We see cross builds taking many hours also on the weaver project. I need to do a good bit of cleanup on this project, but plan to revist this. Ping me on CNCF slack if you're still working on this/need this. |
Use Docker actions and metadata-action to build the image for
linux/arm, linux/arm64, linux/amd64
.Right now it will use
edge
as tag for the latest commit onmain
instead oflatest
(that's also the default for the action). Andlatest
for the latest tag.That's what I've seen in all the projects I've used. Let me know if that works.
Supersedes:
Closes: