Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiarch Docker images #127

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lucacome
Copy link
Contributor

@lucacome lucacome commented Jan 6, 2023

Use Docker actions and metadata-action to build the image for linux/arm, linux/arm64, linux/amd64.

Right now it will use edge as tag for the latest commit on main instead of latest (that's also the default for the action). And latest for the latest tag.
That's what I've seen in all the projects I've used. Let me know if that works.

Supersedes:

Closes:

@lucacome lucacome requested a review from a team January 6, 2023 13:32
@lucacome lucacome force-pushed the add-multiarch-support branch from 601b87c to aeb81c8 Compare January 6, 2023 13:41
@lucacome
Copy link
Contributor Author

is there anybody around that can approve the workflow run? @arminru ? 😅

@lucacome
Copy link
Contributor Author

fixed the error @arminru

@lucacome
Copy link
Contributor Author

I need one more re-run 😅

@lucacome
Copy link
Contributor Author

The build is taking a really long time and GitHub kills it after 6 hours, maybe we could just add arm64 for now? I’m looking into cross compiling but it’s not that straightforward.

@bripkens
Copy link

bripkens commented Sep 8, 2023

Any update on this one? I could use this as well.

@tigrannajaryan
Copy link
Member

@lucacome do you plan to work on this? I tried building from your branch but the build failed for me.
I think we can skip arm and add just arm64 for now.

@lucacome
Copy link
Contributor Author

yeah I can resume working on this @tigrannajaryan I was waiting for somebody to review it 🙂

@tigrannajaryan
Copy link
Member

@lucacome I think this needs a rebase to resolve conflicts and also because many of dockerfile dependency versions have been updated since the PR was first created.

I am happy to review it.

@lucacome lucacome force-pushed the add-multiarch-support branch 5 times, most recently from db75429 to 3a8e91f Compare February 14, 2024 20:26
@tigrannajaryan
Copy link
Member

@lucacome thank you for updating the PR. Sorry for late reply, I missed the notification that the PR was updated.

I see that the build passes now, but I do not see anywhere in the output that it also builds the arm version. Can you help me understand?

Signed-off-by: Luca Comellini <[email protected]>
@lucacome lucacome force-pushed the add-multiarch-support branch from 23c26ed to 4f348f2 Compare July 15, 2024 04:46
@lucacome
Copy link
Contributor Author

lucacome commented Jul 15, 2024

@tigrannajaryan I've resumed working on this. I split the two builds into two different runners but the arm64 still takes 3.5 hours.

I'm looking into cross-compiling but it's not been very successful. Not sure if we still want to merge this in the meantime to start building for arm64. It shouldn't be too bad once everything is cached if there aren't too many changes.

@jsuereth
Copy link
Contributor

@lucacome We see cross builds taking many hours also on the weaver project. I need to do a good bit of cleanup on this project, but plan to revist this. Ping me on CNCF slack if you're still working on this/need this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants