-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
any_of markdown output is misleading if each set only has one member #33
Comments
I am not a native speaker, so I cannot judge properly which is the best phrase to use here.
|
I think if at least one set has more than one member, the current phrasing is clear and in these cases I would keep it as-is. |
This should be changed back once open-telemetry/build-tools#33 is resolved & the updated build tools available.
* Remove rpc.jsonrpc.method, clarify rpc.method instead. * Add PR#. * Clarify client side code.namespace/function. * Use "ref" instead of "constraint: any_of". This should be changed back once open-telemetry/build-tools#33 is resolved & the updated build tools available. Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
* Remove rpc.jsonrpc.method, clarify rpc.method instead. * Add PR#. * Clarify client side code.namespace/function. * Use "ref" instead of "constraint: any_of". This should be changed back once open-telemetry/build-tools#33 is resolved & the updated build tools available. Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
* Remove rpc.jsonrpc.method, clarify rpc.method instead. * Add PR#. * Clarify client side code.namespace/function. * Use "ref" instead of "constraint: any_of". This should be changed back once open-telemetry/build-tools#33 is resolved & the updated build tools available. Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Related: #293 |
Closing this since we no longer support |
E.g. see https://github.com/open-telemetry/opentelemetry-specification/blob/v1.0.1/specification/trace/semantic_conventions/database.md#connection-level-attributes
Obviously the set here is
{"net.peer.name", "net.peer.ip"}
, so you need both. Except: This is wrong! There are two sets, one contains onlynet.peer.name
and the other onlynet.peer.ip
.I think if each set contains only one member, the text above the list MUST change to "At least one of the following
sets ofattributes is required:" (without thesets of).The text was updated successfully, but these errors were encountered: