Skip to content

Commit

Permalink
Change default stability level to experimental
Browse files Browse the repository at this point in the history
Co-authored-by: Liudmila Molkova <[email protected]>
  • Loading branch information
arminru and lmolkova committed Jul 24, 2023
1 parent 8c61609 commit d69cfc5
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 3 deletions.
5 changes: 5 additions & 0 deletions semantic-conventions/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ Please update the changelog as part of any significant pull request.

## Unreleased

## v0.20.0

- Change default stability level to experimental
([#189](https://github.com/open-telemetry/build-tools/pull/189))

## v0.19.0

- Render notes on metric semconv tables
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ def parse(
)
msg = f"Semantic convention stability set to deprecated but attribute '{attr_id}' is {stability}"
raise ValidationError.from_yaml_pos(position, msg)
stability = stability or semconv_stability or StabilityLevel.STABLE
stability = stability or semconv_stability or StabilityLevel.EXPERIMENTAL
sampling_relevant = (
AttributeType.to_bool("sampling_relevant", attribute)
if attribute.get("sampling_relevant")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@
| [`test.exp_attr`](labels_expected.md) | boolean | | | Required |
| [`test.stable_attr`](labels_expected.md) | boolean | ![Stable](https://img.shields.io/badge/-stable-lightgreen)<br> | | Required |
| [`test.deprecated_attr`](labels_expected.md) | boolean | | | Required |
| [`test.def_stability`](labels_expected.md) | boolean | ![Stable](https://img.shields.io/badge/-stable-lightgreen)<br> | | Required |
| [`test.def_stability`](labels_expected.md) | boolean | | | Required |
<!-- endsemconv -->
Original file line number Diff line number Diff line change
Expand Up @@ -489,7 +489,7 @@ def test_stability(self):

attr = model.attributes[3]
self.assertEqual(attr.attr_id, "def_stability")
self.assertEqual(attr.stability, StabilityLevel.STABLE)
self.assertEqual(attr.stability, StabilityLevel.EXPERIMENTAL)

model = list(semconv.models.values())[1]
self.assertEqual(len(model.attributes), 2)
Expand Down

0 comments on commit d69cfc5

Please sign in to comment.