Skip to content

Commit

Permalink
remove duplicate code
Browse files Browse the repository at this point in the history
  • Loading branch information
jamesmoessis committed Jan 25, 2022
1 parent f4aef51 commit ac430a6
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -449,12 +449,6 @@ def _render_group(self, semconv, parameters, output):
)
)

if (
isinstance(semconv, MetricSemanticConvention)
and self.render_ctx.is_metric_table
):
self.to_markdown_metric_table(semconv, output)

attr_to_print = []
attr: SemanticAttribute
for attr in sorted(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,6 @@
The following attributes SHOULD be included on all HTTP metrics for both server and client.

<!-- semconv metric.http -->
| Attribute | Type | Description | Examples | Required |
|---|---|---|---|---|
| [`http.host`](../../trace/semantic_conventions/http.md) | string | The value of the [HTTP host header](https://tools.ietf.org/html/rfc7230#section-5.4). An empty Host header should also be reported, see note. [1] | `www.example.org` | See attribute alternatives |
| [`http.method`](../../trace/semantic_conventions/http.md) | string | HTTP request method. | `GET`; `POST`; `HEAD` | Yes |
| [`http.scheme`](../../trace/semantic_conventions/http.md) | string | The URI scheme identifying the used protocol. | `http`; `https` | See attribute alternative |
| [`http.status_code`](../../trace/semantic_conventions/http.md) | int | [HTTP response status code](https://tools.ietf.org/html/rfc7231#section-6). | `200` | No |

**[1]:** When the header is present but empty the attribute SHOULD be set to the empty string. Note that this is a valid situation that is expected in certain cases, according the aforementioned [section of RFC 7230](https://tools.ietf.org/html/rfc7230#section-5.4). When the header is not set the attribute MUST NOT be set.
<!-- endsemconv -->

## HTTP Client
Expand Down

0 comments on commit ac430a6

Please sign in to comment.