Rename Optional requirement level to Opt-In

open-telemetry · Feb 17, 2023 · 85d73c9 · 85d73c9
1 parent 6baebe9
commit 85d73c9
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 11 deletions.
diff --git a/semantic-conventions/semconv.schema.json b/semantic-conventions/semconv.schema.json
@@ -341,7 +341,7 @@
 				{
 					"properties": {
 						"requirement_level": {
-							"description": "specifies the attribute requirement level. Can be 'required', 'conditionally_required', 'recommended', or 'optional'. When omitted, the attribute is 'recommended'. When set to 'conditionally_required', the string provided as <condition> MUST specify the conditions under which the attribute is required.",
+							"description": "specifies the attribute requirement level. Can be 'required', 'conditionally_required', 'recommended', or 'opt_in'. When omitted, the attribute is 'recommended'. When set to 'conditionally_required', the string provided as <condition> MUST specify the conditions under which the attribute is required.",
 							"oneOf": [
 								{
 									"const": "required"
@@ -378,7 +378,7 @@
 									]
 								},
 								{
-									"const": "optional"
+									"const": "opt_in"
 								}
 							]
 						},

diff --git a/semantic-conventions/src/opentelemetry/semconv/model/semantic_attribute.py b/semantic-conventions/src/opentelemetry/semconv/model/semantic_attribute.py
@@ -32,7 +32,7 @@ class RequirementLevel(Enum):
     REQUIRED = 1
     CONDITIONALLY_REQUIRED = 2
     RECOMMENDED = 3
-    OPTIONAL = 4
+    OPT_IN = 4
 
 
 class StabilityLevel(Enum):
@@ -137,7 +137,7 @@ def parse(
                 "required": RequirementLevel.REQUIRED,
                 "conditionally_required": RequirementLevel.CONDITIONALLY_REQUIRED,
                 "recommended": RequirementLevel.RECOMMENDED,
-                "optional": RequirementLevel.OPTIONAL,
+                "opt_in": RequirementLevel.OPT_IN,
             }
             requirement_level_msg = ""
             requirement_level_val = attribute.get("requirement_level", "")

diff --git a/semantic-conventions/src/opentelemetry/semconv/templating/markdown/__init__.py b/semantic-conventions/src/opentelemetry/semconv/templating/markdown/__init__.py
@@ -156,8 +156,8 @@ def to_markdown_attr(
                 # We put the condition in the notes after the table
                 self.render_ctx.add_note(attribute.requirement_level_msg)
                 required = f"Conditionally Required: [{ len(self.render_ctx.notes)}]"
-        elif attribute.requirement_level == RequirementLevel.OPTIONAL:
-            required = "Optional"
+        elif attribute.requirement_level == RequirementLevel.OPT_IN:
+            required = "Opt-In"
         else:  # attribute.requirement_level == Required.RECOMMENDED or None
             # check if there are any notes
             if (

diff --git a/semantic-conventions/src/tests/data/markdown/ref/rpc.yaml b/semantic-conventions/src/tests/data/markdown/ref/rpc.yaml
@@ -23,7 +23,7 @@ groups:
         requirement_level: required
         brief: 'It describes the server port the client is connecting to'
       - ref: net.peer.name
-        requirement_level: optional
+        requirement_level: opt_in
         brief: override brief.
         note: override note.
       - ref: net.sock.peer.addr

diff --git a/semantic-conventions/src/tests/data/yaml/errors/wrong_multiple_requirement_levels.yaml b/semantic-conventions/src/tests/data/yaml/errors/wrong_multiple_requirement_levels.yaml
@@ -9,5 +9,5 @@ groups:
         type: boolean
         brief: 'test'
         requirement_level: required
-        requirement_level: optional
+        requirement_level: opt_in
         examples: [true, false]
diff --git a/semantic-conventions/src/tests/data/yaml/metrics.yaml b/semantic-conventions/src/tests/data/yaml/metrics.yaml
@@ -34,7 +34,7 @@ groups:
     unit: "{cartons}"
     attributes: 
       - ref: http.method
-        requirement_level: optional
+        requirement_level: opt_in
       - ref: bar.egg.type
         requirement_level: 
           conditionally_required: "if available to instrumentation."
diff --git a/semantic-conventions/syntax.md b/semantic-conventions/syntax.md
@@ -94,7 +94,7 @@ member ::= id value [brief] [note]
 requirement_level ::= "required"
          |   "conditionally_required" <condition>
          |   "recommended" [condition] # Default if not specified
-         |   "optional"
+         |   "opt_in"
 
 # EXPERIMENTAL: Using this is NOT ALLOWED in the specification currently.
 sampling_relevant ::= boolean
@@ -231,7 +231,7 @@ An attribute is defined by:
    It carries no particular semantic meaning but can be used e.g. for filtering
    in the markdown generator.
 - `requirement_level`, optional, specifies if the attribute is mandatory.
-   Can be "required", "conditionally_required", "recommended" or "optional". When omitted, the attribute is "recommended".
+   Can be "required", "conditionally_required", "recommended" or "opt_in". When omitted, the attribute is "recommended".
    When set to "conditionally_required", the string provided as `<condition>` MUST specify
    the conditions under which the attribute is required.
 - `sampling_relevant`, optional EXPERIMENTAL boolean,