Skip to content

Commit

Permalink
remove scope prefix
Browse files Browse the repository at this point in the history
  • Loading branch information
dashpole committed Aug 5, 2022
1 parent 3c4f7a7 commit 012cbbc
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
<!-- semconv scope -->
| Attribute | Type | Description | Examples | Requirement Level |
|---|---|---|---|---|
| `scope.short_name` | string | The single-word name for the instrumentation scope. | `mylibrary` | Recommended |
| `short_name` | string | The single-word name for the instrumentation scope. | `mylibrary` | Recommended |
<!-- endsemconv -->
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
groups:
- id: scope
prefix: scope
prefix:
type: scope
brief: >
Instrumentation Scope attributes
attributes:
Expand Down
2 changes: 1 addition & 1 deletion semantic-conventions/src/tests/data/yaml/scope.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
groups:
- id: scope-id
prefix: scopeprefix
prefix:
type: scope
brief: >
Instrumentation Scope attributes
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -676,13 +676,13 @@ def test_scope_attribute(self):

expected = {
"id": "scope-id",
"prefix": "scopeprefix",
"prefix": "",
"type": "scope",
"extends": "",
"brief": "Instrumentation Scope attributes",
"n_constraints": 0,
"attributes": [
"scopeprefix.short_name",
"short_name",
],
}
self.semantic_convention_check(list(semconv.models.values())[0], expected)
Expand Down

0 comments on commit 012cbbc

Please sign in to comment.