-
Notifications
You must be signed in to change notification settings - Fork 55
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Added test for omitting requirement level
Signed-off-by: Alexander Wert <[email protected]>
- Loading branch information
1 parent
82ec0ff
commit 004e711
Showing
4 changed files
with
41 additions
and
0 deletions.
There are no files selected for viewing
9 changes: 9 additions & 0 deletions
9
semantic-conventions/src/tests/data/markdown/omit_requirement_level/expected.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
# Common Attributes | ||
|
||
<!-- semconv http(omit_requirement_level) --> | ||
| Attribute | Type | Description | Examples | | ||
|---|---|---|---| | ||
| `http.method` | string | HTTP request method. | `GET`; `POST`; `HEAD` | | ||
| `http.url` | string | Full HTTP request URL in the form `scheme://host[:port]/path?query[#fragment]`. Usually the fragment is not transmitted over HTTP, but if it is known, it should be included nevertheless. | `https://www.foo.bar/search?q=OpenTelemetry#SemConv` | | ||
| `http.target` | string | The full request target as passed in a HTTP request line or equivalent. | `/path/12314/?q=ddds#123` | | ||
<!-- endsemconv --> |
25 changes: 25 additions & 0 deletions
25
semantic-conventions/src/tests/data/markdown/omit_requirement_level/http.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
groups: | ||
- id: http | ||
type: span | ||
prefix: http | ||
brief: 'This document defines semantic conventions for HTTP client and server Spans.' | ||
note: > | ||
These conventions can be used for http and https schemes | ||
and various HTTP versions like 1.1, 2 and SPDY. | ||
attributes: | ||
- id: method | ||
type: string | ||
requirement_level: required | ||
sampling_relevant: false | ||
brief: 'HTTP request method.' | ||
examples: ["GET", "POST", "HEAD"] | ||
- id: url | ||
type: string | ||
brief: > | ||
Full HTTP request URL in the form `scheme://host[:port]/path?query[#fragment]`. | ||
Usually the fragment is not transmitted over HTTP, but if it is known, it should be included nevertheless. | ||
examples: ['https://www.foo.bar/search?q=OpenTelemetry#SemConv'] | ||
- id: target | ||
type: string | ||
brief: 'The full request target as passed in a HTTP request line or equivalent.' | ||
examples: ['/path/12314/?q=ddds#123'] |
4 changes: 4 additions & 0 deletions
4
semantic-conventions/src/tests/data/markdown/omit_requirement_level/input.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
# Common Attributes | ||
|
||
<!-- semconv http(omit_requirement_level) --> | ||
<!-- endsemconv --> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters