-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed boldness in the table #145
Conversation
I was thinking about this today but the only good way to help people seemed having the same table on a website where the same table is interactive so people can change sorting etc. The easiest way to do this is create a table in notion and make it available on Web, and then we just link from here. Wdyt? |
Idk, I'd rather keep it simple |
I think that rule 2 is better. |
Yep, I think so, too. Let's see what Jarrett thinks. |
I'm OK with both. |
@L-M-Sherlock it's ready to be merged |
And btw, I changed the names a little bit, so don't forget to update them in superiority.py and elsewhere too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I want to discuss this a bit. Right now we don't have a clear guideline on how to highlight the best result. We could use one of these two rules:
Regarding the current case, in the unweighted table FSRS-5 recency outperforms GRU-P-short. If we go by rule 1, we shouldn't highlight it, and we shouldn't highlight GRU-P-short either. If we go by rule 2, we should highlight both.
@brishtibheja @user1823 bikeshedding time!