Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed boldness in the table #145

Merged
merged 7 commits into from
Jan 1, 2025

Conversation

Expertium
Copy link
Contributor

@Expertium Expertium commented Dec 30, 2024

I want to discuss this a bit. Right now we don't have a clear guideline on how to highlight the best result. We could use one of these two rules:

  1. If an algorithm outperforms all other algorithms on all 3 metrics (aka it's a clear winner), highlight its name. If it only outperforms other algorithms on 1-2 metrics, do not highlight any algorithm names.
  2. If an algorithm outperforms all other algorithms on all 3 metrics, highlight its name. If it only outperforms other algorithms on 1-2 metrics, highlight the name of every algorithm that is the best according to at least one metric. This means that up to 3 algorithm names can be highlighted.

Regarding the current case, in the unweighted table FSRS-5 recency outperforms GRU-P-short. If we go by rule 1, we shouldn't highlight it, and we shouldn't highlight GRU-P-short either. If we go by rule 2, we should highlight both.

@brishtibheja @user1823 bikeshedding time!

@brishtibheja
Copy link

I was thinking about this today but the only good way to help people seemed having the same table on a website where the same table is interactive so people can change sorting etc.

The easiest way to do this is create a table in notion and make it available on Web, and then we just link from here. Wdyt?

@Expertium
Copy link
Contributor Author

Idk, I'd rather keep it simple

@user1823
Copy link
Contributor

I think that rule 2 is better.

@Expertium
Copy link
Contributor Author

Yep, I think so, too. Let's see what Jarrett thinks.

@L-M-Sherlock
Copy link
Member

I'm OK with both.

@Expertium
Copy link
Contributor Author

@L-M-Sherlock it's ready to be merged

@Expertium
Copy link
Contributor Author

Expertium commented Dec 31, 2024

And btw, I changed the names a little bit, so don't forget to update them in superiority.py and elsewhere too
EDIT: I did it myself

Copy link
Member

@L-M-Sherlock L-M-Sherlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@L-M-Sherlock L-M-Sherlock merged commit 6f97fdf into open-spaced-repetition:main Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants