Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to FSRS-5 #664

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Update to FSRS-5 #664

merged 2 commits into from
Jul 10, 2024

Conversation

L-M-Sherlock
Copy link
Member

@L-M-Sherlock L-M-Sherlock commented Jul 10, 2024

No description provided.

@brishtibheja
Copy link

Welcome, FSRS-5! Thanks for this, L.M.Sherlock ♥

@L-M-Sherlock L-M-Sherlock merged commit dd066ff into main Jul 10, 2024
@L-M-Sherlock L-M-Sherlock deleted the update-to-FSRS-5 branch July 10, 2024 06:26
@chrislongros
Copy link

chrislongros commented Jul 10, 2024

There is a typo in the link for the custom scheduling script here: https://github.com/open-spaced-repetition/fsrs4anki/releases/tag/v5.0.0

Does fsrs-5 introduce short term stability etc?

@L-M-Sherlock
Copy link
Member Author

Thanks, I have fixed it just now.

Yes, FSRS-5 considers the short term reviews, which will update the memory state.

@chrislongros
Copy link

chrislongros commented Jul 11, 2024

When do you expect becoming stable, if you can estimate ?
I disabled the build-in FSRS and used the FSRS-5 custom scheduling. I also have the FSRS Helper addon but I get the following message: Please either enable FSRS in your deck options or disable the FSRS Helper addon.

@L-M-Sherlock
Copy link
Member Author

I'm updating the built-in FSRS to v5, and it will take a week. But I don't know when the next release of Anki will be out.

You don't need to disable built-in FSRS.

@chrislongros
Copy link

Having const display_memory_state = true;
I see the stats of multiple cards that I reviewed before.
2024_05:55:13

@L-M-Sherlock
Copy link
Member Author

I can't reproduce this problem. Could you provide detail guide to reproduce it?

@chrislongros
Copy link

chrislongros commented Jul 12, 2024

I run the latest git version of Anki repo. I have FSRS enabled and copied the custom FSRS-5 scheduler to the appropriate box. Set the max interval at 90 and the "display memory state" variable to true. I do my reviews from a filtered deck. The first card shows the memory state at the bottom. After reviewing the next cards it shows multiple boxes with memory states of what I assume to be other cards.

I think I didn't have this problem when I disabled the FSRS and just had the custom v5 scheduler. Must reproduce it when I am at home.

@chrislongros
Copy link

chrislongros commented Jul 12, 2024

The problem appears only with the FSRS Helper addon enabled. When I disable all the addons it shows normally.

@L-M-Sherlock
Copy link
Member Author

I guess you enable the add-on's display_memory_state?

@chrislongros
Copy link

chrislongros commented Jul 12, 2024

Oops yeah, I disabled it and it now runs as expected...

@abdmohrat
Copy link

I pasted the schedular to custom scheduling and updated my parameters, but it does not seem to affect the collection. The helper addon is rescheduling the cards based on the built in FSRS not the one in custom scheduling. I tried changing the retention rate in custom scheduling but this does not change anything, while changing the retention rate in the built in FSRS does change the review amount.
displaying the memory state from the custom schedular is working.
I am using the latest version of Anki and the helper addon as well.

@brishtibheja
Copy link

The rescheduling isn't happening based on what's inside 'custom scheduling' might be more of a helper add-on "issue" rather than of FSRS-5.

@jjy1000
Copy link

jjy1000 commented Jul 20, 2024

1.我更新了自定义排程FSRS5,也在使用FSRSanki的插件,我不知道这两个之间是否相冲突,因为我并没有选择改动anki中插件选项,例如重新安排负载平衡之类的选项,不知道这是否阻碍自定义排程的运转?
2.不知道何时能在anki插件中实现5的更新?
3.一直有个疑惑,在我卡组多的时候,卡片也随之增加,不知道FSRS是否会整体考虑卡片的总数量,例如每天学习的记忆负荷压力,毕竟随着知识卡片的不断累积,每天需要复习卡片总数量的也在增加。
4.考虑过能够实现商业付费?毕竟有时候付费能够支持该项目的持续和运转

@L-M-Sherlock
Copy link
Member Author

@jjy1000

  1. 两个不冲突
  2. 得等 Anki 内置 FSRS-5
  3. 你学的新卡片多,复习量自然会增加,和你牌组数量多寡并无关系
  4. 不考虑,收费了我就要承担很多责任,现在我随时都可以不干了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants