-
-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging V23 of Reactime #325
Conversation
Co-authored-by: Jesse Rosengrant <jollywizrobe>
…odyContainer.scss
…tom two containers to their min-content at a min or 5% of total at a max. remaining ~90% is handled by 1fr, 1 fraction of the remaining space after calculating the bottom two.
…ot best practice and should revisit later to make dynamic. For now, moving on to other UI issues.
…'t start there are a few errors
… settings. Is now nested inside of state-container as it should be. Also added a console.log to background script import action to try to see what tabsObj looks like.
… the toggleRecord button.
…psing arrow and putting labels into actionToolContainer. committing before I mmake some style changes so that I can save my progress.
…tionContainer function on MainContainer
…nto dependencies
Co-authored-by: Jesse Rosengrant <jollywizrobe>
…'t start there are a few errors
…ssume true rather than empty object--this should help with 'no target' issue). Commented out port forEach loop in background.js on connect as it causes errors and is not necessary. Thinking of adding a new reducer function that fires on context menu click to update current tab in state.
… to add tabsObj instance upon the contextMenu being clicked.
…. will grab the info of the tab that invoked reactime, and create a tabsObj entry for it so that error container and other functions have that info available later
…hat now. added more console logs. Planning to reassign the linkFiber on line 23 of index.ts in backend to use LinkFiber instead of linkFiberInitialization
…r and margin changed
-fixed navlinks for performance sub-tabs, diff route tabs, and statecontainer state/diff tabs so they stay highlighted on click -fixed formatting for performance tab component details
Merging diff route back into dev
…indow width is less than 1000
…emove the 50 vertical offset
Second to last merge before launch
updates to readme's and also one small change to package.json npm run build, shifting the openssl legacy option to npm run buildlegacy
…ks now and we're done
Final merge from dev
@jollywizrobe is attempting to deploy a commit to the Reactime Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me. ship it.
This merge brings Reactime up to Version 23.0. Changes:
-New look to the UI
-Updated package dependencies
-Improved stability of app loading
-Improved node map