Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up test FMUs #764

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Clean up test FMUs #764

merged 1 commit into from
Jun 24, 2024

Conversation

kyllingstad
Copy link
Member

This fixes most of the issues described in #763. In particular, I have:

  • removed FMUs with obscure origins
  • removed unused FMUs (and some other unused test files)
  • properly specified the origin and licence for the remaining FMUs
  • modified tests so they only use the remaining FMUs

What I have not done is to banish pre-built FMUs entirely from the repo. That requires more discussion.

This fixes most of the issues described in #763. In particular, I have:

- removed FMUs with obscure origins
- removed unused FMUs (and some other unused test files)
- properly specified the origin and licence for the remaining FMUs
- modified tests so they only use the remaining FMUs
@kyllingstad kyllingstad added the bug Something isn't working label Jun 17, 2024
@kyllingstad kyllingstad self-assigned this Jun 17, 2024
@kyllingstad kyllingstad added the enhancement New feature or request label Jun 17, 2024
Copy link
Member

@restenb restenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyllingstad kyllingstad merged commit 6682586 into master Jun 24, 2024
20 checks passed
@kyllingstad kyllingstad deleted the bugfix/763-clean-up-fmus branch June 24, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants