Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing for 0.10.0 release #726

Merged
merged 2 commits into from
Dec 5, 2022
Merged

Conversation

restenb
Copy link
Member

@restenb restenb commented Dec 2, 2022

Seems we are now ready to release!

Please review the changelog updates. I'll proceed with the release once this is approved.

One question about release: in order to push a tagged artifact to JFrog, the easiest way is to tag manually with Git as 0.10.0, and push it? From reading the GitHub Action scripts, that seems to be what's going on.

VERSION="v$(<version.txt)"
if [[ $GITHUB_REF == refs/tags/* ]] && [[ $REFNAME == $VERSION ]]; then CHANNEL="stable"

So if I have it right it'll go something like this; merge this, tag master as 0.10.0, force push version.txt with 0.10.0 to master, and new 0.10.0 release artifacts should be built and uploaded to stable channel? Please do correct me if I'm wrong ... :)

@markaren
Copy link
Contributor

markaren commented Dec 2, 2022

libcosim is automatically uploaded to stable when making a GitHub release (which tags it). Why would you consider force pushing? Some PR would increase the version number prior to releasing (probably this one).

@restenb
Copy link
Member Author

restenb commented Dec 2, 2022

I didn't see version.txt being updated in the pull for the last release, so I assumed it was force pushed to master at some point?

This means all I need to do is merge this, and then release from the GitHub GUI via releases->draft new release?

Edit; I'm just confusing myself :) - version.txt is currently correct at 0.10.0 of course. It just needs to be updated after the release. That might have just been done with a force push to master last time I guess.

@markaren
Copy link
Contributor

markaren commented Dec 2, 2022

Yes, merge this then make a GitHub release with a tag matching the current version. Conan is then automatically triggered.

Updating the version after the fact has been done with both trivial PRs and direct pushes to master. I see that the latter has been most used. So just a regular push to master (no force push) would suffice I guess.

Example of previsous version bump PR: #567

CHANGELOG.md Outdated
@@ -3,6 +3,19 @@ All notable changes to libcosim will be documented in this file. This includes n

This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html)

### [v0.10.0] - 2022-12-02
##### Changed
* GCC8 artifact builds have been removed, and GCC9 artifact builds added. GCC7 is still supported.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gcc7 was also removed from the CI

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@restenb restenb merged commit 763df18 into master Dec 5, 2022
@restenb restenb deleted the preparing-for-0-10-0-release branch December 5, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants