Some performance tweak #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eidekrist
reviewed
Mar 4, 2022
src/cosim/slave_simulator.cpp
Outdated
| values_[i] = iterator->second(values_[i], deltaT); | ||
| const auto it = back_refs_.find(ref); | ||
| if (it != back_refs_.end()) { | ||
| values_[it->second] = entry.second(values_[it->second], deltaT); |
There was a problem hiding this comment.
I'm wondering about the need for back_refs_. Isn't the array index (it->second here) stored in exposedVariables_.at(ref).arrayIndex?
There was a problem hiding this comment.
I think you are right, adjusted accordingly.
markaren
reviewed
Mar 4, 2022
eidekrist
reviewed
Mar 4, 2022
src/cosim/slave_simulator.cpp
Outdated
| @@ -227,14 +227,10 @@ class set_variable_cache | |||
| references_.emplace_back(ref); | |||
| values_.emplace_back(exposedVariables_.at(ref).lastValue); | |||
| } | |||
| const auto index = exposedVariables_.at(ref).arrayIndex; | |||
There was a problem hiding this comment.
Since we are talking performance;
exposedVariables_.at(ref) is called at least two times in this loop. It might make sense to define it as a local variable before line 224.
There was a problem hiding this comment.
Thanks, updated accordingly.
ljamt
approved these changes
Mar 28, 2022
kyllingstad
reviewed
Mar 30, 2022
| gsl::span<const value_reference> real_variables, | ||
| gsl::span<const value_reference> integer_variables, | ||
| gsl::span<const value_reference> boolean_variables, | ||
| gsl::span<const value_reference> string_variables) const |
There was a problem hiding this comment.
Why was const removed here?
There was a problem hiding this comment.
Added it back, I think I removed it in the previous version (but not needed in the final version).
kyllingstad
approved these changes
Mar 30, 2022
# Conflicts: # tests/proxyfmu_integration_unittest.cpp
# Conflicts: # include/cosim/slave.hpp # src/cosim/slave_simulator.cpp # tests/proxyfmu_integration_unittest.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following updates are for further performance improvement:
1.Additional placement ofLIBCOSIM_NO_FMI_LOGGINGfor disabling logging instep_finished_placeholderstep_finished_placeholderand assignednullptrto the callback pointer.cosim::slave::get_variablesdoes not createcosim::slave::variable_valuesfor each time it's invocation, instead copies data to the argument that is passed to the function.get_variables, see the updated test cases.set_variable_cache::modfiy_and_get,std::unordered_map<value_reference, size_t> back_refs_is used to only update variable values that are subject to modification (via modifier). This avoids unnecessary iteration of all variables in each simulation step.