Link dependencies dynamically #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes #595.
kyllingstad
added a commit
to open-simulation-platform/cosim-cli
that referenced
this pull request
Jun 3, 2020
This change accompanies open-simulation-platform/libcosim#596, and includes the other libraries which are now dynamically linked to libcosim in the dist/lib folder.
|
This fails on Windows because the |
|
Nevermind, I see that it's supposed to be built by the win-conan workflows, but they're failing for some other reason. I'll fix that. |
kyllingstad
added a commit
to open-simulation-platform/cosim-cli
that referenced
this pull request
Jun 4, 2020
This change accompanies open-simulation-platform/libcosim#596, and adds the now-dynamically-linked dependencies in the dist/lib folder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #595.
I'm only setting
shared=Truefor our direct dependencies, since those are the ones we link against, so I also reordered therequireslist to make it obvious which ones they are.