Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose model_description through execution #602

Closed
eidekrist opened this issue Jun 23, 2020 · 0 comments · Fixed by #603
Closed

Expose model_description through execution #602

eidekrist opened this issue Jun 23, 2020 · 0 comments · Fixed by #603
Labels
enhancement New feature or request

Comments

@eidekrist
Copy link
Member

Client code has access to the simulator interface via cosim::execution::get_simulator(). This is done such that client code (in our case libcosimc and cosim4j) can access a simulator's model_description object. Instead of exposing the entire simulator interface, it i suggested to only expose a simulator's model_description object.
@eidekrist eidekrist added the enhancement New feature or request label Jun 23, 2020
eidekrist added a commit that referenced this issue Jun 23, 2020
@eidekrist
#602 Replace get_simulator() with get_model_description()
23ddc11
@eidekrist eidekrist mentioned this issue Jun 23, 2020
Merged
eidekrist added a commit that referenced this issue Jul 1, 2020
@eidekrist
Expose only model description through execution (#603)
af8570d 
* #602 Replace get_simulator() with get_model_description()

* Const ref observable.name() and observable.model_description()

* Revert "Const ref observable.name() and observable.model_description()"

This reverts commit 1ce83fd

* Don't return const reference to model_description object.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expose only model description through execution open-simulation-platform/libcosim
1 participant
@eidekrist