Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async_slave calls set_XXX_variables with empty data #166

Closed
markaren opened this issue Feb 6, 2019 · 1 comment
Closed

async_slave calls set_XXX_variables with empty data #166

markaren opened this issue Feb 6, 2019 · 1 comment
Labels
wontfix This will not be worked on

Comments

@markaren
Copy link
Contributor

markaren commented Feb 6, 2019

At each time step, async_slave and pseudo_async_slave tries to call set_XXX_variables even when there is no data to set. Subsequently, inheriting classes as well as instances of cse::slave are tasked with checking the validity of the data passed to them. IMO, the functions should not be called in the first place. Ask someone to implement cse::slave and they will probably either not check the validity of the input data or throw an exception if the data is invalid!

What has been done for the current v1::fmu and v2::fmu implementations is that they just return. IMO, new implementations should not have to copy this approach.

markaren pushed a commit that referenced this issue Feb 6, 2019
@markaren
Copy link
Contributor Author

I think it's safe to close this. It works as is, new slave implementations just have to be observant and validate the received input.

@markaren markaren added the wontfix This will not be worked on label Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant