You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At each time step, async_slave and pseudo_async_slave tries to call set_XXX_variables even when there is no data to set. Subsequently, inheriting classes as well as instances of cse::slave are tasked with checking the validity of the data passed to them. IMO, the functions should not be called in the first place. Ask someone to implement cse::slave and they will probably either not check the validity of the input data or throw an exception if the data is invalid!
What has been done for the current v1::fmu and v2::fmu implementations is that they just return. IMO, new implementations should not have to copy this approach.
The text was updated successfully, but these errors were encountered:
At each time step,
async_slave
andpseudo_async_slave
tries to call set_XXX_variables even when there is no data to set. Subsequently, inheriting classes as well as instances ofcse::slave
are tasked with checking the validity of the data passed to them. IMO, the functions should not be called in the first place. Ask someone to implementcse::slave
and they will probably either not check the validity of the input data or throw an exception if the data is invalid!What has been done for the current
v1::fmu
andv2::fmu
implementations is that they just return. IMO, new implementations should not have to copy this approach.The text was updated successfully, but these errors were encountered: