Provide trend data for multiple variables #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 21, 2018 14:40
…ere TrendLoop and CommandLoop write to SimulationStatus simultaneously
eidekrist
requested review from
jornsv,
ljamt,
hplatou,
restenb and
kyllingstad
ljamt
approved these changes
Jan 2, 2019
|
You are probably right :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves #43, providing trend data for multiple variables.
I also discovered a race condition where three loops were accessing the SimulationStatus struct at the same time, causing a crash when removing all trend variables and simultaneously extracting trend values. Seems to be fixed by adding a mutex-ish lock to the SimulationStatus struct.
Also removed the unused memory info from the JsonResponse struct.
This is linked to cse-client PR #24