Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress measure #359

Open
wants to merge 25 commits into
base: 2.4.0-dev
Choose a base branch
from

Conversation

tristanmenard
Copy link

@tristanmenard tristanmenard commented Nov 5, 2024

Q A
Feature branch/test site URL
Fixed issues
Related version 2.4.0-dev
Bugfix, feature or docs? Feature
  • Keeps backward-compatibility
  • Includes tests
  • Updated docs
  • Updated config forms
  • Added CHANGELOG entry

Changes from the previous PR:

  • Re-organized everything into classes built upon the Indicator class.
  • Corrected math for cases where the desired direction of progress differs from the direction to the target. When the initial value achieves the target, the desired direction of progress and the direction to the target are opposite, which previously led to incorrect results.
  • Corrected math for cases where values are < 0 (invert the desired direction of progress when values are < 0)
  • Added the ability to choose which series and/or units to use for the progress calculations in the metadata files. If there is no headline for the indicator, the user can also select disaggregations. Some examples below.
    • To specify the series and unit for an indicator with a headline:
    progress_calculation_options:
    - series: Series1
      unit: Unit1
    
    • To specify the series/unit and disaggregation for an indicator without a headline:
    progress_calculation_options:
    - series: Series1
      unit: Unit1
      disaggregation: {'Geography': 'Canada', 'Gender': 'Women'}
    
    • It is possible to choose multiple series/units/disaggregations:
    progress_calculation_options:
    - series: Series1
      unit: Unit1
      disaggregation: {'Geography': 'Canada', 'Gender': 'Women'}
    - series: Series2
      unit: Unit1
    
  • Enabled progress calculations for indicators with no headline but many sub-indicator series. The minimum calculated progress score among the series is taken as the progress score for the indicator.
  • Implemented a scaling factor to reduce the fixed progress thresholds when the initial value is near some natural limit for the indicator (for example if an indicator cannot exceed 100%) for indicators with qualitative targets.
  • Added a progress column that can be used to override the values in the progress calculations. Allows for data that is inappropriate for the progress measure calculation to be converted into a form that is appropriate.

@tristanmenard
Copy link
Author

@brockfanning Currently, the progress calculation is done inside OutputOpenSdg, but it seems to be running the calculation for each language. Ideally, the progress calculation could be done only once. Any ideas where to move the call to IndicatorProgress so that it doesn't redo the calculations for every language?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants