Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add OSCR documentation #358

Merged
merged 7 commits into from
Jul 30, 2024
Merged

feat: Add OSCR documentation #358

merged 7 commits into from
Jul 30, 2024

Conversation

BekahHW
Copy link
Member

@BekahHW BekahHW commented Jul 30, 2024

Description

Adds OSCR to:

  • glossary
  • Contrib insights
  • Link in repo pages

Related Tickets & Documents

closes #345

Mobile & Desktop Screenshots/Recordings

Steps to QA

  1. Go to /features/contributor-insights/
  2. Go to /welcome/glossary/#oscr

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

@BekahHW BekahHW requested a review from a team as a code owner July 30, 2024 13:38
@BekahHW BekahHW requested a review from a team July 30, 2024 13:38
@netlify Netlify
Copy link

netlify bot commented Jul 30, 2024 •
edited
Loading

✅ Deploy Preview for saucedocs ready!

Name Link
🔨 Latest commit 9d0ce11
🔍 Latest deploy log https://app.netlify.com/sites/saucedocs/deploys/66a90fcad242b90008d495ad
😎 Deploy Preview https://deploy-preview-358--saucedocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

nickytonline
nickytonline approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@nickytonline nickytonline left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small typo, but looks great! 🚢

@bdougie
Copy link
Member

bdougie commented Jul 30, 2024

@isabensusan can you give this a quick review?

Also per @nickytonline feedback in slack, I think we will need to add more context on the card or profile in regards to how the OSCR is calculated (perhaps already being explored).

@isabensusan isabensusan self-requested a review July 30, 2024 15:07
isabensusan
isabensusan approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@isabensusan isabensusan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left one minor, non-blocking, comment!

docs/features/contributor-insights.md Outdated Show resolved Hide resolved
jpmcb
jpmcb approved these changes Jul 30, 2024
View reviewed changes
docs/features/contributor-insights.md Outdated Show resolved Hide resolved
docs/welcome/glossary.md Show resolved Hide resolved
@BekahHW BekahHW merged commit 6e2c010 into main Jul 30, 2024
11 checks passed
@BekahHW BekahHW deleted the feat/oscr branch July 30, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isabensusan isabensusan isabensusan approved these changes

@jpmcb jpmcb jpmcb approved these changes

@nickytonline nickytonline nickytonline approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Add OSCR
5 participants
@BekahHW @bdougie @nickytonline @jpmcb @isabensusan