Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Issues Section #268

Closed

Conversation

smhussain5
Copy link
Contributor

@smhussain5 smhussain5 commented Mar 3, 2024

Description

This PR addresses 2 TODO items in #249 😄

  • Add information about it, change the format in this section to undordered list, and adjust some wording for better read and understanding.

    • L29-40: Used ALERTS because suggested copy with ":::note text :::" was not rendering as alerts.
  • Capitalize the "code of conduct" term in the last paragraph.

    • Noticed there was 2 "Code of Conduct" lines that were uncapitalized, so I did both
      • L20: Capitalization of "Code of Conduct"
      • L37: Capitalization of "Code of Conduct"

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Fixes #249

@smhussain5 smhussain5 requested a review from a team as a code owner March 3, 2024 01:42
Copy link

netlify bot commented Mar 3, 2024

👷 Deploy request for docs-open pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 9b471db

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @smhussain5,
Thank you for working on this! 🙌

I have left a review for you to fix. 😊

I have some points to address here. Also for your future reference, it would be best that you:

  1. Read the README and Contributing Guidelines of a project before you work on your changes. And don't hesitate to ask questions if you're in doubt.

  2. Always run the project locally to test the changes.

    This project is built on Docusaurus. And that's the reason why your changes can't be applied here because they are alert syntax for GitHub. You will easily notice this if you've run this project locally. 🙂

  3. I see that you deleted parts of the PR form. Although you might not have to fill everything, you don't want to delete/modify the template. Maintainers always review everything in the form, and often will ask to fill necessary information that contributors missed. Also, you can read the note towards the end of our form:

    <!-- note: PRs with deleted sections will be marked invalid -->

That being said, I'm closing this PR.

Please create another PR, and attach a screenshot of the page with the changes rendered on your local machine.

Please let me know if you have any question/help!

Thank you.

Comment on lines +33 to 41
> [!TIP]
> If an issue is not assigned, it is assumed to be available for anyone to work on. Please assign yourself to an issue before working on it to avoid conflicts.

- Issues with the `needs triage` label are unavailable to `.take` until they are triaged and the label is removed. Feel free to check on the issue regularly if you want to work on it.
- If you contribute to the project for the first time, you can search for issues with `good first issue` or `bug` labels in the repository. Please only self-assign a `good first issue` one time.

> [!NOTE]
> Please only self-assign a `good first issue` once.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the [!TIP] and [!NOTE] to what has been asked in the issue, which are :::info and :::note.

And please give proper indentation to them as what has shown in the copy in the issue.

@adiati98 adiati98 closed this Mar 3, 2024
@adiati98
Copy link
Member

adiati98 commented Mar 3, 2024

Fixed in #269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Update "Issues" section in the "Introduction to Contributing" chapter
2 participants