Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: format and wording adjustments in workspaces, contributors and repo insights sections #262
fix: format and wording adjustments in workspaces, contributors and repo insights sections #262
Changes from 42 commits
17d59e4
d79065b
b59ac79
e54af03
a344a52
02807ac
97fdf7f
bc1e30f
cfccdb4
99c811f
7fea06f
874b32b
6e8e1a7
7ce6801
24a53fd
cb65ae0
41f97b9
97f793d
07b56a0
5925ce0
b9807bd
43a8be7
2f65cf8
8f4473e
60142fa
a0fb0b4
e0d0c86
0739d45
a6e0359
31e9224
8c4ef92
8643223
5bd9bf8
eb15330
e34c592
66c6df0
c2e704a
dc03816
a72682d
8bc85eb
1c80cf9
ff12f01
817bd8b
c470748
fec21e9
c72c1b2
9ae9565
773af1d
2590e09
a22d34e
d4261fd
c17ab5b
1c60bd1
49eb4a4
2bf1fb8
e338c8f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying this out again. I think start by creating a workspace name can be confusing and can be a bit misleading here.
So, there are 2 ways to add repositories to a workspace:
Start by clicking the "Add repositories" button. Then, choose an option to add repostories: Search for repositories, Import a GH org, or Import repositories. Afterwards, add the name of the workspace (this is required), and add description (optional).
Start by clicking the "Edit" button. Then, add name of the workspace, the repositories, and update/save the workspace.
We can either include both ways, or include the first one, that make more sense to create a workspce for the first time. But either way, we want to inform that adding the workspace name is required.
We can do it in this PR, or create a new issue for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are two issues here: Maybe the issue here is "How to Add repositories to a workspace" and "How to Add Repos to Your Personal Workspace."
We can have two separate lines.
I believe that only the personal workspace has the edit button. That's because it also takes you to the settings page where you can add workspace members, change the visibility, and upgrade. Which is something I'm going to add to the docs after we get this merged in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, now I see. You're right. Only "Your personal workspace" that has the edit button in the beginning.
Creating new workspace will take us the creation form as below. But once it's created, it also has an edit button.
I remember that you will add more details to the workspaces, but I'm not sure if this one of them. So, I throw this here, just in case. π
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this could be a separate issue. What do you think @BekahHW?